[coreboot] LAR TODO
mylesgw at gmail.com
Thu Mar 13 03:45:42 CET 2008
> >> >> Myles? Could you prepare a patch which #ifdefs the code instead of
> >> >> removing it?
> > One part that was strange to me was that I first tried adding elfboot.o
> > archelfboot.o to the beginning of the list of object files. This broke
> > coreboot. It still finished building, but would not boot on QEMU. I
> > surprised that it broke it, but didn't investigate further.
> Did you make distclean in between? v3 dependency handling is something
> between screwed and nonexistent. It does work sometimes, though.
Yes, I did. It didn't work.
> Sorry, but the chunk above is a real mess. Can't you move the
> conditional chunk to the end and avoid the else path completely?
Yep, this is the ugly place I was talking about. I had tried to add them to
the beginning of the list, and it wouldn't build. I tried at the end this
time and it worked. I still think it's a little strange that the order
> The patch would get my Ack except for the Makefile chunk I complained
> about. Please rework that.
Signed-off-by: Myles Watson <mylesgw at gmail.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 4049 bytes
Desc: not available
More information about the coreboot