[coreboot] buildrom rom size patch

Myles Watson mylesgw at gmail.com
Mon Mar 10 20:53:37 CET 2008


On Mon, Mar 10, 2008 at 12:43 PM, Ward Vandewege <ward at gnu.org> wrote:
>
> On Fri, Mar 07, 2008 at 11:02:58AM -0700, Myles Watson wrote:
>  > This patch makes use of the CONFIG_COREBOOT_V3_ROM_SIZE variable in buildrom.
>  > The hope is that eventually we could do some math with it if we want.  The
>  > only problem is that when you don't have it set, it gives you an error when
>  > you do make menuconfig.  Here is the error:
>  >
>  > #
>  > # using defaults found in .config
>  > #
>  > .config:23:warning: symbol value '' invalid for COREBOOT_V3_ROM_SIZE
>  > .config:83:warning: symbol value '' invalid for LAB_PAUSE
>  >
>  > Notice that LAB_PAUSE has the same problem.  Setting the value to be a string
>  > instead of an int removes the warning, but removes the error checking as well.
>  >
>  > Myles
>  >
>  > Signed-off-by: Myles Watson <mylesgw at gmail.com>
>
>  I've build-tested this with the alix.1c target (which needs some patching to
>  make it work, I'm going  to send those to the list when I'm happy with them).
>  This patch generates a valid lar image of the specified size (at least lar -l
>  tells me so).
>
>  Acked-by: Ward Vandewege <ward at gnu.org>

Rev. 137.

Thanks,
Myles




More information about the coreboot mailing list