[coreboot] flashrom issues found??
ron minnich
rminnich at gmail.com
Sun Mar 9 08:31:23 CET 2008
On Sat, Mar 8, 2008 at 11:24 PM, <joe at smittys.pointclark.net> wrote:
> Ok,
> I think I know what is going on here after looking at the uniflash
> source code. I found this comment in the Intel programming code "Do
> not program FF, erase will result in all FF's so it's not necessary.
> Besides, 2*FF means reset ..."
>
> So, I removed this function from jedec.c and rebuilt flashrom.
>
> // dumb check if erase was successful.
> for (i = 0; i < total_size; i++) {
> if (bios[i] != (uint8_t) 0xff) {
> printf("ERASE FAILED @%d, val %02x!\n", i, bios[i]);
> return -1;
> }
> }
>
> It seems to work fine now. Is this a bug for Intel ICH series???
if it is we should not modify jedec.c -- that seems to work many
places. Rather, we need to make a special function -- ich only -- and
use that on ich.
thanks
ron
More information about the coreboot
mailing list