[coreboot] [PATCH]ich_gpio_dump util ACK?

ron minnich rminnich at gmail.com
Sun Mar 9 06:48:37 CET 2008

A few things caught my eye:
+	if (iopl(3)) { printf("You need to be root.\n"); exit(1); }

Just use perror. This is going to be confusing if there is an error
and you're running as root :-)

There are a few cases where there are pci cleanups and frees and such
and then an immediate exit. I applaud the sentiment but, really,
you're just as safe exiting without the cleanup. Just a thought ...

thanks, this is neat stuff.


More information about the coreboot mailing list