[coreboot] [PATCH] Make RAM check configurable via Kconfig
rminnich at gmail.com
Sat Mar 8 20:44:21 CET 2008
On Sat, Mar 8, 2008 at 11:39 AM, Uwe Hermann <uwe at hermann-uwe.de> wrote:
> Nice trick, but it won't work in this case. Kconfig variables are
> #defined to 1 if they're selected in menuconfig, but they're not
> defined at all otherwise.
Which, now that I think of it, is probably why they always have a
defined value in linux and are not just undefined. By going with
variables that are undefined or not, we lose some nice ways to write
clear code and get optimization.
> I still prefer the version in my patch because it makes the majority of
> the code look clean and short (no #ifdefs). We could add a '_maybe'
> prefix/suffix to function names which are conditionally compiled like
> that (I think some Linux code does that).
I still have concerns that it will confuse people. At first glance it
looks like we're going to test ram. Oh, we're not, because of this
config variable? It's just not clear to me.
But it may be I am just out of sync :-)
More information about the coreboot