[coreboot] [PATCH] Make RAM check configurable via Kconfig

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Sat Mar 8 00:31:22 CET 2008

On 08.03.2008 00:10, ron minnich wrote:
> So, I am curious.
> I see this:
> 	ram_check(0, 640 * 1024);
> in a file. Could I be forgiven in thinking that a ram check might be
> done? I realize this is the "linux style" but I have never
> particularly liked it.
> What is wrong with
> #ifdef RAMTEST
> 	ram_check(0, 640 * 1024);
> #endif
> What do people prefer? Maybe I am just out of touch.

That's fine with me as well. It all depends on your expectations and how
well you know these config options. Right now, an #ifdef might be the
best solution, especially now that v3 has a lot of momentum and we
expect people less familiar with the code to contribute.



More information about the coreboot mailing list