[coreboot] [PATCH] v3: fix bugs in Geode LX RAMinit

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Fri Mar 7 20:15:23 CET 2008

On 07.03.2008 19:16, Marc Jones wrote:
> Carl-Daniel Hailfinger wrote:
>> Marc? It would be nice if you could read through the code and verify the 
>> things I did.
>> northbridge/amd/geodelx/raminit.c:auto_size_dimm() checks for the 
>> mathematically impossible condition of a value being above and below the 
>> specified range at the same time. Change it to check for out-of-range.
>> arch/x86/geodelx/geodelx.c:set_delay_control() is missing a break, it 
>> will keep going and mess up DRAM timings.
>> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
> Strange, The raminit in v2 was correct. Both changes look right to me. I 
> didn't build or run it. I am a bit swamped in something else right now.

The raminit in v2 was fixed in r2899 | rminnich | 2007-10-26 with this log:
> The lxraminit change fixes a bug (&& used instead of ||) [...]
> Signed-off-by: Ronald G. Minnich <rminnich at gmail.com>
> Acked-by: Peter Stuge <peter at stuge.se>

On 07.03.2008 19:16, Marc Jones wrote:
> Ron, can you test this?
> BTW, Thanks to Carl-Daniel, Ron, and Uwe for recent work on LX. You are 
> making good improvements to the code.

You're welcome.

> Acked-by: Marc Jones <marc.jones at amd.com>

Thanks! I will wait a bit before committing to give Ron the chance to test.



More information about the coreboot mailing list