[coreboot] Makefile simplification for v3

Uwe Hermann uwe at hermann-uwe.de
Fri Mar 7 00:16:06 CET 2008


On Thu, Mar 06, 2008 at 07:23:45AM -0700, Myles Watson wrote:
> 
> 
> > -----Original Message-----
> > From: Stefan Reinauer [mailto:stepan at coresystems.de]
> > Sent: Thursday, March 06, 2008 7:07 AM
> > To: Myles Watson
> > Cc: Coreboot
> > Subject: Re: [coreboot] Makefile simplification for v3
> > 
> > * Myles Watson <mylesgw at gmail.com> [080305 19:27]:
> > >  	$(Q)# QEMU wants bios.bin:
> > >  	$(Q)# Run "qemu -L build/ -serial stdio -hda /dev/zero".
> > > -	$(Q)printf "  CP      $(subst $(shell pwd)/,,$(obj)/bios.bin)\n"
> > > -	$(Q)cp $@ $(obj)/bios.bin
> > > +	$(Q)# printf "  CP      $(subst $(shell pwd)/,,$(obj)/bios.bin)\n"
> > > +	$(Q)# cp $@ $(obj)/bios.bin
> > >  	$(Q)echo "Coreboot ROM Image:" > $(obj)/coreboot.map
> > >  	$(Q)$(obj)/util/lar/lar -l $(obj)/coreboot.rom >>
> > $(obj)/coreboot.map
> > >  	$(Q)(echo; echo "Stage 0/1 Map:") >> $(obj)/coreboot.map
> > 
> > I think this sneaked in... Please make sure you don't commit this.
> 
> You're right.  It should be a separate patch.  I'll make sure I don't commit
> it with the rest of this patch.  
> 
> I think it would be correct to remove it because it is mainboard specific.
> Someone who wants to automate testing could use a symbolic link to
> coreboot.rom from their BIOS directory.

QEMU expects a file called bios.bin, that's why this is done. Now you
can just type 'qemu -L build ...' and it works. Not critical, but nice
to have, and it doesn't really hurt to leave it in.


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org




More information about the coreboot mailing list