[coreboot] [PATCH] v3: Fix two NULL pointer dereferences in device code

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Wed Mar 5 13:56:21 CET 2008

On 05.03.2008 03:54, ron minnich wrote:
> Acked-by: Ronald G. Minnich <rminnich at gmail.com>

Thanks, committed in r631.

> This was on db800 right? I need to get a failure case.

db800, norwich, probably any AMD board triggered the NULL dereference in 
device/device.c. There is still one NULL dereference left in 
device/device.c and I need you to answer my question to fix it 
completely. Then again, you probably asked for a way to reproduce to see 
this. With the patch applied, look for "ERROR: bus->dev is NULL" in the 
logs and notice if that appears, there is garbage in the log later on.

>> Ron? You can probably tell if bus->dev==NULL in read_resources(bus)
>> is an error or if we need to handle it cleanly.

All boards (including qemu) triggered the NULL pointer in 
device/pci_device.c. Look for "None (not found)" in the logs with the 
patch applied. You'll see it 33 times in the qemu boot log.



More information about the coreboot mailing list