[coreboot] r3393 - trunk/util/flashrom

Stefan Reinauer stepan at coresystems.de
Sun Jun 29 12:38:17 CEST 2008


Carl-Daniel Hailfinger wrote:
> On 29.06.2008 01:46, Stefan Reinauer wrote:
>   
>> Carl-Daniel Hailfinger wrote:
>>     
>>>> The sparse debug printfs create a wrong impression here.
>>>>     
>>>>         
>>> Then we should definitely apply my patch to make sure nobody gets a
>>> wrong impression in the future.
>>>       
>> Absolutely; and a couple more like that.
>>     
>
> Good. Care to ack my patch?
>   
Acked-by: Stefan Reinauer <stepan at coresystems.de>


> That's a pretty good idea. Perhaps we want to refine that proposal a bit
> more with debug bitmasks. Then again, that might be overkill.
>   
shouldn't make things much more complex, does it?

> More ICH SPI debug messages are definitely needed before 1.0. Log levels
> are post-1.0 material IMHO.
>
>   
yep


-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.dehttp://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866





More information about the coreboot mailing list