[coreboot] flashrom: Cache probed id:s

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Tue Jun 24 12:43:14 CEST 2008


On 24.06.2008 11:57, Stefan Reinauer wrote:
> Peter Stuge wrote:
>   
>>> There are three ways to solve this:
>>> - Keep probe results per function per chip size (ugly)
>>>     
>>>       
>> I like a variation on this:
>>
>> - Cache probe results per function per start address
>>
>> I don't think it's so ugly because as you pointed out the address
>> probed is input to the sequence.
>>
>> Needs a little more code changed though.
>>   
>>     
> Can you try to do this outside of the probe function?
>
> ie. use a hash made from ptr to probe function and size (or rather base
> address!)
>   

No hash please (unless you are willing to prove there are no
collisions). For our purposes, a sorted list of struct {function pointer
and base address} is ideal.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the coreboot mailing list