[coreboot] [Fwd: Re: [patch][v2] cs5536 usb port4 configuration - new v3 patch]
Marc.Jones at amd.com
Sat Jul 12 01:54:46 CEST 2008
Carl-Daniel Hailfinger wrote:
> Hi Marc,
> please ignore my other mail regarding your equivalent v2 patch. I had
> not seen this mail yet and assumed divergence.
> Overall, I like the current style a little bit more, but the current
> style also has these ugly divisions by sizeof(u32) which I dislike.
> If anybody else acks this patch, feel free to add
> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
> to your v2 and v3 patch.
> The only nitpick I have is a slight whitespace issue below.
Thanks,I'll doulbe check the whitespace before I check it in.
Senior Firmware Engineer
(970) 226-9684 Office
mailto:Marc.Jones at amd.com
More information about the coreboot