[coreboot] [PATCH] v3: Fix ADL MSM800SEV build

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Fri Jul 11 18:50:27 CEST 2008


On 11.07.2008 15:56, Uwe Hermann wrote:
> See patch.
>
> Someone with the board should check if '15,2' is really correct, and
> whether it makes sense to enable IDE or not for this board.
>
> Thanks, Uwe.
>   

> Fix a build-error because of a missing 'enable_ide'.
>   

In theory, this should not cause a build error. Then again, our DTS
concept still needs some tweaks.

> Signed-off-by: Uwe Hermann <uwe at hermann-uwe.de>
>
> Index: mainboard/adl/msm800sev/dts
> ===================================================================
> --- mainboard/adl/msm800sev/dts	(Revision 694)
> +++ mainboard/adl/msm800sev/dts	(Arbeitskopie)
> @@ -37,6 +37,10 @@
>  		pci at 1,1 {
>  			/config/("southbridge/amd/cs5536/dts");
>  		};
> +		pci at 15,2 {
> +			/config/("southbridge/amd/cs5536/ide");
> +			enable_ide = "1";
>   

What about removing the line above? In theory, stuff should still compile.

> +		};
>  		ioport at 46 {
>  			/config/("superio/winbond/w83627hf/dts");
>  			com1enable = "1";

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the coreboot mailing list