[coreboot] [PATCH] flashrom: Improve coreboot image detection heuristic
Peter Stuge
peter at stuge.se
Fri Jul 4 18:25:53 CEST 2008
On Fri, Jul 04, 2008 at 06:11:54PM +0200, Carl-Daniel Hailfinger wrote:
> + (!isprint(*(const char *)(bios + size - *(walk - 1))) &&
> + (*(const char *)(bios + size - *(walk - 1)))) ||
> + (!isprint(*(const char *)(bios + size - *(walk - 2))) &&
> + (*(const char *)(bios + size - *(walk - 2))))) {
NAK. I would like to fix this in a better way, or not at all. A four
line long condition can simply not be the best way, even in the short
term.
//Peter
More information about the coreboot
mailing list