[coreboot] [LinuxBIOS] [PATCH] buildrom: add extract and busybox-config, uclibc-config targets

Myles Watson myles at pel.cs.byu.edu
Mon Jan 28 18:51:19 CET 2008



> All right, third try.
> 
> On Fri, Jan 11, 2008 at 04:07:37PM -0700, Myles Watson wrote:
> > This patch breaks the dependencies somehow.  Before your patch, I could
> > remove the work/uclibc directory and only uclibc would get rebuilt.  Now
> it
> > rebuilds mkelfimage, the kernel, etc.
> >
> > I looked for the problem, but didn't see it right away.
> 
> It was a little tricky - apparently adding some of those directories as
> prerequisites confused messed things up a bit. The 'stamp' directory
> timestamp ended up newer than the stamp/_unpacked file thus forcing a
> rebuild.
> This was presumably because stamp/_configured was created after stamp and
> stamp/_unpacked.
> 
> Anyway, I fixed the problem by turning the directory prerequisites into
> order-only prerequisites.

It works great for me.  The only thing I would like better is if the target
were added to the end of the customconfig file, so that you wouldn't
accidentally pick up the wrong config.  (i.e., customconfig-qemu or
customconfig-s2891).

I think that could be considered a matter of taste.  Maybe we should add the
custom-config option for the kernel as well.

Thanks,
Myles

Acked-by: Myles Watson <myles at pel.cs.byu.edu>







More information about the coreboot mailing list