[coreboot] v3 compilation failures

Stefan Reinauer stepan at coresystems.de
Mon Jan 28 14:28:46 CET 2008


* Marc Jones <marc.jones at amd.com> [080122 00:01]:
> >> -/* smbus functions */
> >> -int smbus_read_byte(unsigned device, unsigned address);
> > 
> > hmm. So where does the prototype live then?

They should not necessarily be inter-stage prototypes. I think they can
be part of the "initram" stage and stay in there. No?

> >> -/* dram functions */
> >> -void ram_failure(const char *why);
> >> -void ram_initialize(int controllers, void *ctrl);
> > 
> > These are in lib/ram.c and even defined in the documentation ;-)
> > 
> > What should we do about that?
> 
> You have a point. There should be a standard prototype but lib.h seemed 
> to be a random place for them.

Don't think we want them in the bootblock. It's too big already anyways.

-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.dehttp://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866




More information about the coreboot mailing list