[coreboot] PATCH: Add Spansion S25FL016A to flashrom

Peter Stuge peter at stuge.se
Sun Jan 27 08:08:48 CET 2008

On Sun, Jan 27, 2008 at 03:15:58AM +0100, Stefan Reinauer wrote:
> > #define ID is well tested but I'm not adamant in any way. You're
> > basically asking for less information in source and more at run
> > time. I like more info at run time but I still think it would be
> > nice to have IDs in the code.
> Not really less information in the source. Just a single place for
> that information. flash.h is the only place where the VENDOR_ID
> defines are defined and the array in flashchips.c is the only place
> where they are used. 
> In fact i think it would add information if we replace the
> VENDOR_ID defines with strings and drop the DEVICE_ID defines
> completely.
>  {"W29C011",     WINBOND_ID,     W_29C011,       128, 128, ...}
> should rather read
>  {"Winbond", "W29C011", 0xda, 0xc1, 128, 128, ...}

I like it.

> > I was also thinking that it would/should be simple to tell
> > flashrom about these flash chip parameters at run time so as to
> > not need a rebuild with as-yet unsupported flash.
> yes, this would be really neat.

I'll think a bit more about this. If someone wants to hack on it go
for it.


More information about the coreboot mailing list