[coreboot] r563 - coreboot-v3/northbridge/amd/geodelx

svn at coreboot.org svn at coreboot.org
Sat Jan 26 05:07:15 CET 2008


Author: rminnich
Date: 2008-01-26 05:07:14 +0100 (Sat, 26 Jan 2008)
New Revision: 563

Modified:
   coreboot-v3/northbridge/amd/geodelx/geodelx.c
   coreboot-v3/northbridge/amd/geodelx/vsmsetup.c
Log:
I hope I am not overstepping the boundaries here, but I feel this is a
cosmetic comment as well. 

We just did lots of coding work to make sure we could call vsmbios. 

So let's actually call it!

P.S. If this is NOT considered a cosmetic comment, feel free to yell at
me :-)

Signed-off-by: Ronald G. Minnich <rminnich at gmail.com>
Acked-by: Ronald G. Minnich <rminnich at gmail.com>



Modified: coreboot-v3/northbridge/amd/geodelx/geodelx.c
===================================================================
--- coreboot-v3/northbridge/amd/geodelx/geodelx.c	2008-01-26 03:45:13 UTC (rev 562)
+++ coreboot-v3/northbridge/amd/geodelx/geodelx.c	2008-01-26 04:07:14 UTC (rev 563)
@@ -313,6 +313,8 @@
  */
 static void geodelx_pci_domain_phase2(struct device *dev)
 {
+	void do_vsmbios(void);
+
 	printk(BIOS_SPEW, ">> Entering northbridge.c: %s\n", __FUNCTION__);
 
 	northbridge_init_early();
@@ -322,9 +324,8 @@
 
 	printk(BIOS_SPEW, "Before VSA:\n");
 	/* print_conf(); */
-#warning Not doing vsm bios -- linux will fail.
 	/* Do the magic stuff here, so prepare your tambourine ;) */
-	/* do_vsmbios(); */
+	do_vsmbios(); 
 	printk(BIOS_SPEW, "After VSA:\n");
 	/* print_conf(); */
 

Modified: coreboot-v3/northbridge/amd/geodelx/vsmsetup.c
===================================================================
--- coreboot-v3/northbridge/amd/geodelx/vsmsetup.c	2008-01-26 03:45:13 UTC (rev 562)
+++ coreboot-v3/northbridge/amd/geodelx/vsmsetup.c	2008-01-26 04:07:14 UTC (rev 563)
@@ -168,7 +168,7 @@
 	return eax;
 }
 
-void do_vsmbios(void *bios)
+void do_vsmbios(void)
 {
 	unsigned char *buf;
 	int i;





More information about the coreboot mailing list