[coreboot] [PATCH] Rename lxbios to nvramtool

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Sat Jan 26 01:50:23 CET 2008


We need to rethink this whole source tree renaming business. It
- messes up svn blame
- causes lots of breakage when you try to go back to versions before the
rename (try it with coreboot v2!)
- introduces inconsistencies in at least half of the patches (some
references to LB are changed, some remain)
- tries to purge all references to the previous name
- messes with local changes in some of the cases.

Sorry Uwe, this is not against you. I have been working with the trees a
lot in the past two weeks and the v2 rename has broken "svn up" to older
versions, svn blame gets interesting etc. Right now I'm working with
multiple trees, some in a state before the rename, some after the rename
and tracking down when some problems were introduced requires me to
switch trees constantly. That makes me really grumpy. If I could go back
in time, I'd stop the whole tree moving/renaming. Project renaming is
OK, but tree renaming is a real pain.


On 25.01.2008 16:37, Uwe Hermann wrote:
> See patch.
>
> This is step 1 in a three-step commit:
>
>  1. Apply patch, commit.
>
>  2. Rename some files:
>     $ svn mv lxbios.c nvramtool.c
>     $ svn mv lxbios.1 nvramtool.c
>     $ svn mv lxbios.spec nvramtool.spec
>     $ svn ci
>
>  3. Rename lxbios directory:
>     $ svn mv lxbios/ nvramtool/
>     $ svn ci
>
> If I get an ACK for the patch, I'll do steps 2 and 3 also, right after
> comitting the patch.
>
> Additionally, the wiki page http://www.coreboot.org/Lxbios
> will then be moved to http://www.coreboot.org/nvramtool.
>   


> Index: lxbios.c
> ===================================================================
> --- lxbios.c	(Revision 3075)
> +++ lxbios.c	(Arbeitskopie)
> @@ -1,5 +1,5 @@
>  /*****************************************************************************\
> - * lxbios.c
> + * nvramtool.c
>   * $Id$
>   *****************************************************************************
>   *  Copyright (C) 2002-2005 The Regents of the University of California.
> @@ -8,9 +8,9 @@
>   *  UCRL-CODE-2003-012
>   *  All rights reserved.
>   *
> - *  This file is part of lxbios, a utility for reading/writing coreboot
> + *  This file is part of nvramtool, a utility for reading/writing coreboot
>   *  parameters and displaying information from the coreboot table.
> - *  For details, see http://coreboot.org/Lxbios.
> + *  For details, see http://coreboot.org/nvramtool.
>   

NACK. Either remove the terminating full stop or separate it from the
URL with a space.

>   *
>   *  Please also read the file DISCLAIMER which is included in this software
>   *  distribution.
>   

> Index: lbtable.c
> ===================================================================
> --- lbtable.c	(Revision 3075)
> +++ lbtable.c	(Arbeitskopie)
> @@ -9,9 +9,9 @@
>   *  UCRL-CODE-2003-012
>   *  All rights reserved.
>   *
> - *  This file is part of lxbios, a utility for reading/writing coreboot
> + *  This file is part of nvramtool, a utility for reading/writing coreboot
>   *  parameters and displaying information from the coreboot table.
> - *  For details, see http://coreboot.org/Lxbios.
> + *  For details, see http://coreboot.org/nvramtool.
>   

Same here.

>   *
>   *  Please also read the file DISCLAIMER which is included in this software
>   *  distribution.
>   

> Index: lbtable.h
> ===================================================================
> --- lbtable.h	(Revision 3075)
> +++ lbtable.h	(Arbeitskopie)
> @@ -8,9 +8,9 @@
>   *  UCRL-CODE-2003-012
>   *  All rights reserved.
>   *
> - *  This file is part of lxbios, a utility for reading/writing coreboot
> + *  This file is part of nvramtool, a utility for reading/writing coreboot
>   *  parameters and displaying information from the coreboot table.
> - *  For details, see http://coreboot.org/Lxbios.
> + *  For details, see http://coreboot.org/nvramtool.
>   

Same here.

>   *
>   *  Please also read the file DISCLAIMER which is included in this software
>   *  distribution.
> @@ -29,8 +29,8 @@
>   *  59 Temple Place, Suite 330, Boston, MA 02111-1307 USA.
>  \*****************************************************************************/
>  
> -#ifndef LXBIOS_LBTABLE_H
> -#define LXBIOS_LBTABLE_H
> +#ifndef LBTABLE_H
> +#define LBTABLE_H
>   

Now that does not make sense. Why LBtable?

>  
>  #include "common.h"
>  
>   

Regards,
Carl-Daniel





More information about the coreboot mailing list