[coreboot] [LinuxBIOS] Patch file for ld/fedora 8 issue as promised...

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Tue Jan 22 17:13:30 CET 2008


On 22.01.2008 16:47, Marc Karasek wrote:
> Been away for the weekend.  Sun was closed on Monday. 
>
> Signed of by Marc Karasek <marc.karasek at sun.com>
>
>
> Carl-Daniel Hailfinger wrote:
>   
>> On 09.01.2008 16:13, Marc Karasek wrote:
>>   
>>     
>>> Attached is the latest.
>>>
>>> It uses -ge instead of == or >.  This will take care of any time that
>>> there are more than 1 build-id in the ld -help output.
>>>
>>> Myles Watson wrote:
>>>     
>>>       
>>>> I like the idea of using grep.  It seems much cleaner, and avoids
>>>> that issue.
>>>>
>>>>       
>>>>         
>>>>> Myles Watson wrote:
>>>>>       
>>>>>           
>>>>>> Sorry to be picky, but it seems like this breaks if they mention
>>>>>> build-id more than once in the help in the future.  I think >0 would
>>>>>> be better than ==1.
>>>>>>
>>>>>> With that fixed, or if no one thinks that will ever happen:
>>>>>> Acked-by: Myles Watson <myles at pel.cs.byu.edu>
>>>>>>           
>>>>>>             
>> If we used grep, the buildtarget snippet could probably be made a bit
>> smaller:
>> ld --help | grep -q build-id && EXTRA_LFLAGS+=" -Wl,--build-id=none"
>>
>>
>> Next try (does not (yet?) use grep):
>>
>> Marc, I could not find your Signed-off-by: in the thread. If that patch
>> is OK for you, please sign off on it.
>>
>>
>> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Thanks, r3073.

Regards,
Carl-Daniel




More information about the coreboot mailing list