[coreboot] v3 compilation failures

Stefan Reinauer stepan at coresystems.de
Mon Jan 21 21:34:24 CET 2008


ron minnich wrote:
> On Jan 21, 2008 10:12 AM, Marc Jones <marc.jones at amd.com> wrote:
>
>   
>>> ./include/device/smbus.h:int smbus_read_byte(struct device *dev, u8 addr);
>>> ./device/smbus_ops.c:int smbus_read_byte(struct device *dev, u8 addr)
>>> (introduced in r307)
>>>
>>> ./include/lib.h:int smbus_read_byte(unsigned device, unsigned address);
>>> ./mainboard/artecgroup/dbe61/initram.c:int smbus_read_byte(unsigned
>>> device, unsigned address)
>>> (introduced in r349)
>>>
>>> ./southbridge/amd/cs5536/smbus_initram.c:int smbus_read_byte(u16 device,
>>> u8 address)
>>> (introduced in r344)
>>>
>>>       
>
> I recommend u16 device, u16 address. The address can be up to 10 bits
> as I understand it
> on some versions of smbus. Am I wrong on this however?
>   

I thought a device always has to be struct device? No?

Stefan

-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.dehttp://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 249 bytes
Desc: OpenPGP digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20080121/aa913068/attachment.sig>


More information about the coreboot mailing list