[coreboot] Fixing usage of vendor, device to devid

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Mon Jan 21 00:06:57 CET 2008


On 19.01.2008 08:44, ron minnich wrote:
> This change resolves the earlier report of 'can't find southbridge'
> which was due to dev_find_device not being able
> to find a device in the static tree.
>
> ron
>   
> include/device/device.h
> Remove old vendor,device struct members since we are now using the device_id struct. 
> Change declaration of dev_find_device to use device_id struct. 
>
> device/device_util.c
> Change dev_find_device to use device_id struct instead of vendor, device parameters.
> Add convenience function, dev_find_pci_device, to make it easier for users. 
>
> device/pci_device.c
> Change uses of dev->vendor and dev->device to dev->id. 
> Change prints of dev->vendor, dev->device to use the 
> dev_id_string function. 
>
> device/pci_rom.c
> Change uses of dev->vendor and dev->device to dev->id. 
>
> southbridge/amd/cs5536/cs5536.c
> Change uses of dev_find_device to dev_find_pci_device
>
> southbridge/amd/cs5536/dts
> Add pciid of the cs5536
>
> northbridge/amd/geodelx/dts
> add pciid of the geodelx northbridge. 
>
> util/x86emu/vm86.c
> Change uses of dev_find_device to dev_find_pci_device
>
> With these changes, the chipsetinit function now finds the southbridge in the 
> static tree, which is the first time this has worked in v3. This success
> in turn means that the chipsetinit code is running for the first time. 
> We are still failing in
> "Finding PCI configuration type"
>
> Signed-off-by: Ronald G. Minnich <rminnich at gmail.com>
>   

Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Committed in r558 with one compile warning fixed.


Regards,
Carl-Daniel




More information about the coreboot mailing list