[coreboot] SST25VF016B (2MB) flash on m57sli (IT8716F).

Ronald Hoogenboom ronald at zonnet.nl
Thu Jan 17 22:25:12 CET 2008

On Thu, 2008-01-17 at 00:56 +0100, Carl-Daniel Hailfinger wrote:

> Please see
> http://www.coreboot.org/Development_Guidelines#Sign-off_Procedure for
> details on patch submission. There are two things that block acceptance
> of your patch:
> - A "Signed-off-by:" line is missing. Please add one.

I'll try again now... Sorry for my ignorance (or failure to read the

> The function is probably more specific to IT8716F and chips bigger than
> 512 kByte. Maybe rename the function and have the IT8716F writing code
> switch to you method if the chip is bigger than 512 kB?

I've made it a little more generic, but otoh, the spi.c is sort of less
generic than the filename would suggest, quite IT8716F specific.
I've made all spi flash chips over 512k point to the new functions and
hope that they will all work for them too (I cannot test this). With the
generic functions, it will definately not work because of the 8716's
512k limit, so it won't break anything that is not already broken...
But the lack of block-write seems to me is quite sst chip specific
(remember they have an AAI mode instead, which doesn't play well with
the limited io transfer length options of the IT8716). It might be more
appropriate to have an 'over512k_page_write' for more speed with chips
that do support that. Also the byte program wait time is hard wired to
10 us (following the 25vf016b datasheet). And the block protect
enablement might also NOT be so generic.

> Please try to address the comments above and repost.
> Note: I suggest that the "maximum frequency" stuff could be handled in
> another patch because it requires redesign of some structures (needs
> discussion) and is also is logically another change.

For now, the frequency is set to 33/2 for the new large flash functions,
pending a better approach.

The reworked attached patch also includes the added winbond (previously
known as Nexcom) chips.

Signed-off-by: Ronald Hoogenboom <hoogenboom30 at zonnet.nl>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: over512k.patch
Type: text/x-patch
Size: 9288 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20080117/210bad2f/attachment.patch>

More information about the coreboot mailing list