[LinuxBIOS] [PATCH] v3: Print a message before resetting the processor
duwe at lst.de
Sat Jan 12 01:58:39 CET 2008
On Saturday 12 January 2008, Carl-Daniel Hailfinger wrote:
> After configuring the PLL registers on Geode LX, we have to reset the
> processor. However, nothing in the log tells the user why the processor
> is being reset.
> + printk(BIOS_INFO, "Resetting the processor after PLL "
> + "configuration for the changes to take effect\n");
> /* "Reset the chip" value */
It shouldn't be BIOS_INFO. Resetting the machine is as fundamental as can be,
so always tell this news if someone is listening (-> BIOS_EMERG). IMHO a few
stars might be appropriate as well, but that's a matter of taste. Besides
Acked-by: Torsten Duwe <duwe at lst.de>
More information about the coreboot