[LinuxBIOS] [PATCH] v2: rewrite AMD K* CAR code

[Carl-Daniel Hailfinger]

On 10.01.2008 01:45, Marc Jones wrote:
> Carl-Daniel Hailfinger wrote:
>> On 08.01.2008 23:00, ron minnich wrote:
>>> Actually, if you all want to commit this, I can try it on the sis
>>> board this week.   
>>
>> Well, i'd like to commit, but I'll wait until you (or someone else) have
>> tested it.
>
> We checked this on K8 with DCACHE_RAM_SIZE=0x08000 and it works as
> expected.

Thanks, great!

There's one issue with specific binutils versions, though. The following
sequence trips up a specific gas version with an error message: "Error:
too many positional arguments"

I'd like to blacklist the specific binutils version causing this and
report the bug to the linux distributor.
Jordan, could you give us more details (exact binutils version, name of
distribution, are all updates applied)?

.macro extractmask segs, reg
.if \segs <= 0
 xorl \reg, \reg
.elseif \segs == 1
 movl $0x06000000, \reg
.elseif \segs == 2
 movl $0x06060000, \reg
.elseif \segs == 3
 movl $0x06060600, \reg
.elseif \segs >= 4
 movl $0x06060606, \reg
.endif
.endm

.macro simplemask carsize, windowoffset
 extractmask (((\carsize - \windowoffset) / 0x1000) - 4), %eax
 extractmask (((\carsize - \windowoffset) / 0x1000)), %edx
.endm

simplemask 0x8000, 0


Regards,
Carl-Daniel