[LinuxBIOS] [PATCH] beautify m57sli mptable.c (Was: Fix FireWire...)

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Sun Jan 6 17:26:07 CET 2008

On 06.01.2008 15:01, Torsten Duwe wrote:
> I still owe you a beautification patch.
> On Thursday 20 December 2007, ron minnich wrote:
>> Hi Torsten, why not add the comments and readable indentation right
>> now? once it is committed, it won't happen :-)
> It's not indentation. I found the extra long lines and useless comments 
> extremely ugly and obfuscating.
> This patch would again qualify as trivial by Russ' definition, but coding 
> style matters so I want to bring this to discussion. IMO this is what 
> preprocessor macros were invented for. We now have bus,dev,fn tuples 
> together, and can easily see that 1:0a.0 maps to "pin" 18. Removing all that 
> redundant blurb also makes room for meaningful comments 8-)
> Signed-off-by: Torsten Duwe <duwe at lst.de>

This is a much needed simplification and readability improvement. Thanks!
Generated code seems to be unchanged.

If you drop the #undef lines (or explain why we absolutely need them),
you can take the ack from below.

Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Bonus points if you manage to convert all mptable.c files for MCP55 (or
even, if that task is not too daring, all mptable.c files).
MCP55 mptable.c would be:


More information about the coreboot mailing list