[LinuxBIOS] Patch file for ld/fedora 8 issue as promised...

Marc Karasek Marc.Karasek at Sun.COM
Thu Jan 3 22:15:42 CET 2008


Here is the patch with the ld option check as well. 

I had to make a few changes to Ron's original patch.  One of the 
problems was that CFLAGS was being set as a := in the Makefile and was 
overwriting the += that was in Makefile.settings.  So I added 
DISTRO_CFLAGS and DISTRO_LFLAGS for the two additonal flags.  The reason 
for two was that the build-id option is only used during linking and 
generated warnings if used on a compile line and was not being pulled in 
for the linker lines.  These defines were added to the appropriate 
places in the Makefile via the Config.lb file.



/*********************
Marc Karasek
MTS
Sun Microsystems
mailto:marc.karasek at sun.com
ph:770.360.6415
*********************/



ron minnich wrote:
> On Jan 3, 2008 10:33 AM, Marc Karasek <Marc.Karasek at sun.com> wrote:
>
>   
>> I could add the check to this patch (using awk to check ld) to add the
>> -Wl option to the EXTRA_CFLAGS.
>>     
>
> cool! I'll take it and add it.
>
> ron
>   
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20080103/070169c5/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fixflags2.diff
Type: text/x-patch
Size: 4053 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20080103/070169c5/attachment.diff>


More information about the coreboot mailing list