[coreboot] patch: dbe62

ron minnich rminnich at gmail.com
Fri Feb 29 00:14:40 CET 2008


Committed revision 624.

There's only one nitpick I did not ack on. I put all your other changes in.

On Thu, Feb 28, 2008 at 3:07 PM, Carl-Daniel Hailfinger
<c-d.hailfinger.devel.2006 at gmx.net> wrote:
> On 28.02.2008 23:41, ron minnich wrote:
>
>  > +static const struct wmsr {
>  > +     u32 reg;
>  > +     struct msr  msr;
>  > +}
>
>  Maybe split this and move the struct declaration to a header?
>

I've thought hard about this for a few years. I will let it be for
now, it's such a simple thing and if moved to a .h it becomes one more
'grep for this' type struct.

thanks

ron




More information about the coreboot mailing list