[coreboot] r3119 - trunk/coreboot-v2/src/devices

svn at coreboot.org svn at coreboot.org
Fri Feb 29 00:10:38 CET 2008


Author: duwe
Date: 2008-02-29 00:10:38 +0100 (Fri, 29 Feb 2008)
New Revision: 3119

Modified:
   trunk/coreboot-v2/src/devices/pci_device.c
Log:
In pci_device.c, the class for VGA was not tested properly, leading to
no VGA output from coreboot, even after the boot-rom was executed
properly (CONFIG_PCI_ROM_RUN) or no boot-rom execution with
CONFIG_VGA_ROM_RUN at all. According to the header file device.h, the
class field of struct device is '3 bytes: (base,sub,prog-if)'.

Signed-off-by: Ronald Hoogenboom <hoogenboom30 at zonnet.nl>
Acked-by: Torsten Duwe <duwe at lst.de>



Modified: trunk/coreboot-v2/src/devices/pci_device.c
===================================================================
--- trunk/coreboot-v2/src/devices/pci_device.c	2008-02-26 04:36:52 UTC (rev 3118)
+++ trunk/coreboot-v2/src/devices/pci_device.c	2008-02-28 23:10:38 UTC (rev 3119)
@@ -654,7 +654,7 @@
 	 * is set but CONFIG_PCI_ROM_RUN is not. In this case we skip
 	 * all other option ROM types.
 	 */
-	if (dev->class!=PCI_CLASS_DISPLAY_VGA) 
+	if ((dev->class>>8)!=PCI_CLASS_DISPLAY_VGA)
 		return;
 #endif
 
@@ -670,7 +670,7 @@
 
 #if CONFIG_CONSOLE_VGA == 1
 	/* vga_inited is a trigger of the VGA console code. */
-	if (dev->class == PCI_CLASS_DISPLAY_VGA) {
+	if ((dev->class>>8) == PCI_CLASS_DISPLAY_VGA) {
 	    extern int vga_inited;
 	    vga_inited = 1;
 	}





More information about the coreboot mailing list