[coreboot] lar directory handling patch

Peter Stuge peter at stuge.se
Thu Feb 28 01:11:58 CET 2008

On Wed, Feb 27, 2008 at 01:32:25PM -0700, Myles Watson wrote:
> Here's the updated patch.
> Signed-off-by: Myles Watson <mylesgw at gmail.com>

Like it! Just some small nits about coding style.

Acked-by: Peter Stuge <peter at stuge.se>

> +				len += (name[len-1]=='/'?1:0);

Some like spaces around ? and :

> +	if (verbose()) printf("%s: %s:%s\n",__FUNCTION__,filename,pathname);

Separate lines and space after comma.

>  	// Is it a directory?

C++ comment.

> +		ret = handle_directory(filename,pathname,thisalgo);

Space after commas.

Personally I don't care about these things, terser is better for me,
but I guess we should try to keep the style consistent in the repo.


More information about the coreboot mailing list