[coreboot] r3118 - trunk/coreboot-v2/src/superio/ite/it8716f

svn at coreboot.org svn at coreboot.org
Tue Feb 26 05:36:53 CET 2008

Author: ward
Date: 2008-02-26 05:36:52 +0100 (Tue, 26 Feb 2008)
New Revision: 3118


Temporarily disable the fan control patch from this morning; it turns out to
stop the CPU fan on the m57sli v1.1 (PLCC) entirely, which is less than
desirable. I did not notice before because my board ran fine for about 15
minutes before the CPU overheated.

Thankfully the board has a good failsafe mode - it just switches off when the
CPU gets too hot, without permanent damage.

I'm debugging this and plan to commit a proper fix later in the week.

This is not really trivial, but the tree is dangerous in the current state so
I'm self-acking.

Signed-off-by: Ward Vandewege <ward at gnu.org>
Acked-by: Ward Vandewege <ward at gnu.org>

Modified: trunk/coreboot-v2/src/superio/ite/it8716f/superio.c
--- trunk/coreboot-v2/src/superio/ite/it8716f/superio.c	2008-02-25 22:32:41 UTC (rev 3117)
+++ trunk/coreboot-v2/src/superio/ite/it8716f/superio.c	2008-02-26 04:36:52 UTC (rev 3118)
@@ -62,9 +62,9 @@
 	return inb(port_base + 1);
+/* #ifdef HAVE_FANCTL
 extern void init_ec(uint16_t base);
+#else */
 static void init_ec(uint16_t base)
 	uint8_t value;
@@ -80,7 +80,7 @@
 	printk_debug("FAN_CTL: reg = 0x%04x, writing value = 0x%02x\r\n",
 		     base + 0x14, value | 0x87);
 static void it8716f_init(device_t dev)

More information about the coreboot mailing list