[coreboot] [patch] mkelfimage News to ChangeLog

Martin-Éric Racine q-funk at iki.fi
Mon Feb 25 11:32:49 CET 2008


On 2/25/08, Mart Raudsepp <mart.raudsepp at artecdesign.ee> wrote:
>
>  Ühel kenal päeval, E, 2008-02-25 kell 11:36, kirjutas Martin-Éric
>  Racine:
>
> > This small patch renames News to ChangeLog to match GNU standards.
>  >
>  > Signed-off-by: Martin-Éric Racine <q-funk at iki.fi>
>
>
> NACK
>
>  a) If done, it should be a svn mv, not a patch
>  b) The content is NEWS, not ChangeLog - NEWS is per release summary,
>  which this is, and ChangeLog is per commit. This file seems to be per
>  release.
>
>  I suggest doing a
>  "svn mv News NEWS"

It seems like a botched changelog to me, not a per-release summary, so
I would rename it to ChangeLog.old or something equivalent.

PS: and yes, "svn mv" would have been more efficient.

-- 
Martin-Éric Racine
http://q-funk.iki.fi


More information about the coreboot mailing list