[coreboot] [PATCH] v3: update mainboard dts files to new style

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Sun Feb 17 12:52:47 CET 2008


On 17.02.2008 08:05, Peter Stuge wrote:
> On Sat, Feb 16, 2008 at 09:30:17PM -0800, ron minnich wrote:
>   
>> you mean add a .dts? It makes sense to me.
>>     

There is one big advantage of the current situation: The name of the 
struct generated by the dts matches the path of the dts (slashes are 
replaced with underscores). Once you add a .dts suffix, this is a lot 
less clear. You can of course replace the dot with an underscore as 
well, but then the struct name is 4 chars longer and more ugly.

> I've done this in my working copy:
>
> cd northbridge/amd/geodelx
> svn mv apic apic.dts
> svn mv domain domain.dts
> svn mv pci pci.dts
> cd ../../intel/i440bxemulation
> svn mv domain domain.dts
> cd ../../../southbridge/intel/i82371eb
> svn mv ide ide.dts
> cd ../../../mainboard/pcengines/alix1c
> sed -i '/config.*[^s]");$/s,");,.dts");,' dts
> cd ../../emulation/qemu-x86
> sed -i '/config.*[^s]");$/s,");,.dts");,' dts
>
> This is the patch I got. Will it be enough to commit that if it is
> acked, or do I need to do something else for the svn mv to be
> complete?
>   

Doing the steps above breaks the build for Qemu.

  CC      build/mainboard/emulation/qemu-x86/statictree.o
In file included from /sources/tmptrees/LinuxBIOSv3-tmp4/build/mainboard/emulation/qemu-x86/statictree.c:1:
/sources/tmptrees/LinuxBIOSv3-tmp4/build/statictree.h:5: error: expected identifier or ‘(’ before ‘.’ token
/sources/tmptrees/LinuxBIOSv3-tmp4/build/statictree.h:9: error: expected identifier or ‘(’ before ‘.’ token
/sources/tmptrees/LinuxBIOSv3-tmp4/build/mainboard/emulation/qemu-x86/statictree.c:23: warning: initialization discards qualifiers from pointer target type
/sources/tmptrees/LinuxBIOSv3-tmp4/build/mainboard/emulation/qemu-x86/statictree.c:35: error: expected identifier or ‘(’ before ‘.’ token
/sources/tmptrees/LinuxBIOSv3-tmp4/build/mainboard/emulation/qemu-x86/statictree.c:40: error: ‘domain_0’ undeclared here (not in a function)
/sources/tmptrees/LinuxBIOSv3-tmp4/build/mainboard/emulation/qemu-x86/statictree.c:79: error: expected identifier or ‘(’ before ‘.’ token
/sources/tmptrees/LinuxBIOSv3-tmp4/build/mainboard/emulation/qemu-x86/statictree.c:85: error: ‘pci_1_0’ undeclared here (not in a function)
make: *** [/sources/tmptrees/LinuxBIOSv3-tmp4/build/mainboard/emulation/qemu-x86/statictree.o] Fehler 1

There are a lot more fixups needed before you can commit.
You have to change the dts parser, among other things.

Considering all of the things above, I have to NACK. Sorry.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the coreboot mailing list