[coreboot] rm elfboot and ELF from v3 (not lar)

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Sat Feb 16 01:32:42 CET 2008


On 15.02.2008 22:33, Myles Watson wrote:
> This is another attempt at removing ELF support from v3.  I'll try to
> do a better job of explaining and justifying this time.  The patch
> should be followed by:
> svn rm include/elf_boot.h
> svn rm include/elf.h
> svn rm include/arch/x86/arch/elf.h
> svn rm lib/elfboot.c
> svn rm arch/x86/archelfboot.c
>
> Another follow-on would be to fix lar so it never puts an ELF into the
> lar without parsing it.
>
> Here are my reasons:
> 1. It wasn't being used anyway.
>            Unless you used lar to load the elf in, the Makefile always
> parsed the elf with -e
> 2. It duplicated code.
>            There is no reason for v3 to understand ELF when lar parses it.
> 3. It saves space.
>
> Here's the last little bit of stage0.init.map
>
> Without the patch:
>
> ffffcc8c T rawpnp_write_config
> ffffcca8 T rawpnp_set_logical_device
> ffffcccb T rawpnp_set_iobase
> ffffccf4 T rawpnp_set_enable
> ffffcd19 T rawpnp_enter_ext_func_mode
> ffffcd20 T rawpnp_exit_ext_func_mode
> ffffd51f t __FUNCTION__.1410
> ffffd540 t console_test.1503
> ffffd57b T _estage0_1
> fffffff0 A _ROMTOP
> fffffff0 T _resetjump
>
> With the patch:
>
> ffffc885 T rawpnp_enter_ext_func_mode
> ffffc88c T rawpnp_exit_ext_func_mode
> ffffce20 t console_test.1503
> ffffce5b T _estage0_1
> fffffff0 A _ROMTOP
> fffffff0 T _resetjump
>
> I'm calculating the difference by subtracting the locations of _estage0_1
> fffd57b - fffce5b = 0x720 = 1824 bytes
>
> Not earth-shattering, but significant.
>
> Myles
>
> Signed-off-by: Myles Watson <mylesgw at gmail.com>
>   

Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Please wait for Stefan's comments before committing, though. Making the
code dependent on a Kconfig variable instead of removing it may be a
better first step.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the coreboot mailing list