[coreboot] [PATCH] Move v3 config variables to Kconfig style

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Fri Feb 15 02:33:54 CET 2008


On 15.02.2008 01:26, Peter Stuge wrote:
> On Thu, Feb 14, 2008 at 10:23:56PM +0100, Stefan Reinauer wrote:
>   
>>> I stand corrected. However, the test for the #define being 1 is
>>> superfluous if the #define is a bool.
>>>       
>> Acked-by: Stefan Reinauer <stepan at coresystems.de>
>>     
>
> I'd like to nak. But already committed.
>   

Sorry.

> I would like to be more tolerant to #defines being 0.
>   

If these #defines were 0, we would have a Kconfig bug (at least that's
how I understand it). For non-bool Kconfig variables, #defines still can
be 0 or anything else.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the coreboot mailing list