[coreboot] lar or lzma problems on 64-bit (was Weirdness with lzma setting in v3)

Myles Watson myles at pel.cs.byu.edu
Wed Feb 13 18:20:26 CET 2008

On Feb 12, 2008 9:04 PM, ron minnich <rminnich at gmail.com> wrote:
> how about taking it away from explicit bit widths? Unless the bit
> width of a type absolutely needs to be set, you ought to use an int or
> even unsigned int. Can you try it?
> ron

Because the code uses int a lot more than unsigned int, I used int.
There are still many places where your rule is not followed, but this
works and moves in that direction.

nrv2b.c in particular could use some help.  It doesn't compile if safe
is defined, because of undefined variables.  The input parameter len
is never used either.  I think that should be a separate patch.


Signed-off-by: Myles Watson <myles at pel.cs.byu.edu>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lar.64-bit.patch
Type: text/x-patch
Size: 6948 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20080213/b6002c82/attachment.patch>

More information about the coreboot mailing list