[coreboot] v3: dts and arrays

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Wed Feb 13 17:44:04 CET 2008


I want to reenable the "unwanted VPCI" support, but the dtc does not
like me. Regardless of what I try to store in the dts, the device tree
compiler will barf.

An ideal solution would be the ability to not only specify array
contents, but also array size in the dts. Overriding ability for both
would be even better.

Suggestions?

Regards,
Carl-Daniel

Index: southbridge/amd/cs5536/cs5536.c
===================================================================
--- southbridge/amd/cs5536/cs5536.c	(Revision 590)
+++ southbridge/amd/cs5536/cs5536.c	(Arbeitskopie)
@@ -608,16 +608,13 @@
 	if (sb->enable_ide)
 		ide_init(dev);
 
-#warning Add back in unwanted VPCI support
-#if 0
 	/* Disable unwanted virtual PCI devices. */
-	for (i = 0; (i < MAX_UNWANTED_VPCI) && (0 != sb->unwanted_vpci[i]); i++) {
+	for (i = 0; (i < MAX_UNWANTED_VPCI) && sb->unwanted_vpci[i]; i++) {
 		printk(BIOS_DEBUG, "Disabling VPCI device: 0x%08X\n",
 		       sb->unwanted_vpci[i]);
 		outl(sb->unwanted_vpci[i] + 0x7C, 0xCF8);
 		outl(0xDEADBEEF, 0xCFC);
 	}
-#endif
 	printk(BIOS_SPEW, "cs5536: %s() Exit\n", __FUNCTION__);
 }
 
Index: southbridge/amd/cs5536/dts
===================================================================
--- southbridge/amd/cs5536/dts	(Revision 590)
+++ southbridge/amd/cs5536/dts	(Arbeitskopie)
@@ -57,4 +57,7 @@
 	com2_enable = "0";
 	com2_address = "0x2f8";
 	com2_irq = "3";
+
+	/* Disable unwanted virtualized PCI devices */
+	unwanted_vpci[0] = "0";
 };



-- 
http://www.hailfinger.org/





More information about the coreboot mailing list