[coreboot] [PATCH] v3: move CAR base and CAR size to invisible Kconfig

Stefan Reinauer stepan at coresystems.de
Mon Feb 11 02:03:32 CET 2008

* Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net> [080211 01:57]:
> CAR size and CAR base defines are scattered all over the place. Set them
> centrally from Kconfig, but keep the Kconfig variables hidden.
> That way, they are available everywhere, you don't have to try to guess
> where they are set, and they come with help text if you look at
> arch/x86/Kconfig.
> No semantic changes, although some of the settings really could use an
> overhaul.
> This also is a requirement for my printk buffer patch.
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
NACK. Search the archives for previous discussion on this. The config
system is not there to set code internal only variables. That's what the
arch/x86 cpu dependent include files are there for.

coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.dehttp://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866

More information about the coreboot mailing list