[coreboot] [patch] add MSI MS-7135 support, try three

jakllsch at kollasch.net jakllsch at kollasch.net
Sat Feb 9 20:53:28 CET 2008


On Sat, Feb 09, 2008 at 01:28:01AM +0100, Carl-Daniel Hailfinger wrote:
> Hi Jonathan,
> 
> sorry that your code is still unreviewed. I had a quick look over it, but
> 
> On 02.02.2008 20:41, jakllsch at kollasch.net wrote:
> > Initial support for MSI MS-7135 (K8N Neo3) mainboard. 
~~~~
> > +
> > +#define ASSEMBLY 1
> > +#define __ROMCC__
> >   
> 
> ROMCC reference. Is it necessary although the rest of the code doesn't
> use ROMCC?
> 
> > +
~~~~
> > +#include <arch/romcc_io.h>
> >   
> 
> Same here.

Apparently.  The cache_as_ram_auto.c files looked at (serengeti_cheetah,
a8n_e) have it.  And it doesn't work when I take these lines out.


As I'm sure my PIR tables are wrong, and I don't use them,
I think it would be best if this support didn't get included
until it works and/or is necessary.

 
> > --- src/mainboard/msi/ms7135/irq_tables.c	(revision 0)
> > +++ src/mainboard/msi/ms7135/irq_tables.c	(revision 0)
> > @@ -0,0 +1,265 @@
> > +/*
> 

	Jonathan Kollasch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20080209/2c63d595/attachment.sig>


More information about the coreboot mailing list