[coreboot] [RFC] Error out on implicit declarations

Myles Watson mylesgw at gmail.com
Thu Dec 18 20:28:40 CET 2008


On Thu, Dec 18, 2008 at 12:24 PM, Corey Osgood <corey.osgood at gmail.com>wrote:

> On Thu, Dec 18, 2008 at 11:37 AM, Corey Osgood <corey.osgood at gmail.com>wrote:
>
>> On Thu, Dec 18, 2008 at 10:58 AM, ron minnich <rminnich at gmail.com> wrote:
>>
>>> I like this idea a lot, I have no idea why we did not have that
>>> enabled before ... I'm glad I'm on vacation and you all can fix it :-)
>>
>>
>> I'm all for it. CN700 should be all ready for the change.
>>
>
> I retract that, I was thinking of v3. Attached patch fixes v2.
>
 Index: src/northbridge/via/cn700/vgachip.h
===================================================================
--- src/northbridge/via/cn700/vgachip.h (revision 3818)
+++ src/northbridge/via/cn700/vgachip.h (working copy)
@@ -1,6 +1,6 @@
 /*
 * This file is part of the coreboot project.
- *
+ *;

I'm curious about this extra semicolon.  Besides that:

Acked-by: Myles Watson <mylesgw at gmail.com>

Thanks,
Myles
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20081218/6858871c/attachment.html>


More information about the coreboot mailing list