[coreboot] [PATCH] improve debug output for not matching Vendor/Device ID in pci_rom.c

Pattrick Hueper phueper at hueper.net
Tue Dec 16 13:48:25 CET 2008


i came across this error during YABEL debugging, and adding the
expected values to me makes sense to really see that this is an error.

Cheers, Patty

Signed-off-by: Pattrick Hueper <phueper at hueper.net>
 device/pci_rom.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/device/pci_rom.c b/device/pci_rom.c
index 443f52b..75e08e4 100644
--- a/device/pci_rom.c
+++ b/device/pci_rom.c
@@ -113,8 +113,8 @@ struct rom_header *pci_rom_probe(struct device *dev)
 	       rom_data->vendor, rom_data->device);
 	if (dev->id.pci.vendor != rom_data->vendor || dev->id.pci.device !=
rom_data->device) {
-		       "Device or Vendor ID mismatch Vendor %04x, Device %04x\n",
-		       rom_data->vendor, rom_data->device);
+		       "Device or Vendor ID mismatch Vendor %04x, Device %04x,
expected: Vendor: %04x, Device %04x\n",
+		       rom_data->vendor, rom_data->device, dev->id.pci.vendor,
 		return NULL;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-enhance-error-output-if-ROM-Vendor-Device-and-PCI-Ve.patch
Type: text/x-diff
Size: 1087 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20081216/15bbb084/attachment.bin>

More information about the coreboot mailing list