[coreboot] [PATCH] flashrom: generate OPCODES improved

Peter Stuge peter at stuge.se
Mon Dec 15 05:04:44 CET 2008


Peter Stuge wrote:
> FENG Yu Ning wrote:
> > * add a generic preop-opcode-pair table.
> > 
> > * rename ich_check_opcodes to ich_init_opcodes.
> > 
> > * let ich_init_opcodes do not need to access flashchip structure:
> > 
> >   . move the definition of struct preop_opcode_pair to a better place
> >   . remove preop_opcode_pairs from 'struct flashchip'
> >   . modify ich_init_opcodes and generate_opcodes so that they do not access the
> >     flashchip structure
> > 
> > * call ich_init_opcodes during chipset enable. Now OPCODES generation mechanism
> >   works.
> > 
> > * fix a coding style mistake.
> > 
> > Signed-off-by: FENG yu ning <fengyuning1984 at gmail.com>
> 
> Committed in r3814.

And thank you so much for the great contribution to flashrom! :)


//Peter




More information about the coreboot mailing list