[coreboot] [PATCH] flashrom: generate OPCODES improved

FENG Yu Ning fengyuning1984 at gmail.com
Thu Dec 11 19:13:28 CET 2008

On Thu, Dec 11, 2008 at 1:52 AM, FENG Yu Ning <fengyuning1984 at gmail.com> wrote:
> * call ich_init_opcodes in related ich functions(chip-read, chip-write and
>  direct command), so that the OPCODES generation mechanism finally works.

seems not a very good idea.

I find that OPCODES needs to be initialized before
spi_disable_blockprotest in some general spi commands(spi.c). Of
course I should not call ich_init_opcodes directly there.

How about calling it in ich chipset enabling process?

peter, I regretted that I did not ask about your comments on the
OPCODES generation patch. That might have saved me some time.( I was
about to, but was just too tired to stay up.)

yu ning

More information about the coreboot mailing list