[coreboot] [RFC] Add reviewed-by markers to code sections

ron minnich rminnich at gmail.com
Thu Dec 11 02:19:09 CET 2008


On Wed, Dec 10, 2008 at 5:12 PM, Peter Stuge <peter at stuge.se> wrote:
> Carl-Daniel Hailfinger wrote:
>> In the past, reviews were mostly centered on coding style (not only
>> cosmetics, but also code flow) and general sanity. While that is
>> definitely needed, I propose another layer on top of this:
>>
>> Verification of the code and comments against data sheet
>> recommendations and documentation.
>
> I feel very strongly that we do not need more layers.
>

There are problems anyway. What if the doco are known to be wrong, due
to an NDA, and you can't even say "the doco is wrong".

Sorry, I vote with peter.

ron




More information about the coreboot mailing list