[coreboot] [PATCH] LAR: Don't clobber top 8 bytes

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Wed Dec 3 23:59:01 CET 2008

On 03.12.2008 23:27, ron minnich wrote:
> On Wed, Dec 3, 2008 at 2:02 PM, Stefan Reinauer <stepan at coresystems.de> wrote:
>> In fact the area is not completely clean due to the binutils workaround. We
>> had "nicer" code there, and it broke on Ron's binutils, so we went to the
>> current version. It works, so don't waste time fixing it.

Since the code works, it is pointless to overwrite the result of the
working code in LAR.

> In fact, if anything, can we please fix the cn700?

I don't have the hardware, so I can't fix it. I did fix the C7 CAR code,
but beyond that I can't help.

> these cosmetic patches are not really helping anything.

This patch is not cosmetic and it is needed to fix the broken heuristic
in flashrom for coreboot image detection.



More information about the coreboot mailing list