[coreboot] [PATCH] v3: fix PCI bus scan / device tree interaction

ron minnich rminnich at gmail.com
Sat Aug 30 05:21:28 CEST 2008


On Fri, Aug 29, 2008 at 3:59 PM, Carl-Daniel Hailfinger
<c-d.hailfinger.devel.2006 at gmx.net> wrote:
> On 30.08.2008 00:55, Stefan Reinauer wrote:
>> Carl-Daniel Hailfinger wrote:
>>
>>> By the way, I managed to break dtc while working on this:
>>> dtc only uses dev_fn as identifier for a PCI device. That gets us a name
>>> collision if we have the same dev_fn combination on multiple buses.
>>>
>>>
>>
>> The bus is determined by the position of the device in the device tree.
>> This has never been an issue in v2 or v3.
>>
>
> I was talking about struct names emitted by dtc. They have been broken
> since ages in v3 (probably forever). See my other mail with the dtc
> patch for an example dts which explodes.
>

no, they have not been broken forever, fortunately. when we change to
the syntax of
pci at x,y from the older syntax of an arbitrary name, we broke it.

ron




More information about the coreboot mailing list