[coreboot] patch for global variables

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Thu Aug 28 04:25:44 CEST 2008


On 28.08.2008 03:59, ron minnich wrote:
> well you can try this ...
>
> Patch to support sys_info for qemu.
>   

Looks fine except for one comment which I already changed in the file
you are basing this code on.
Thanks for coming up with this patch so fast.

> Signed-off-by: Ronald G. Minnich <rminnich at gmail.com>
>   

Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

> Index: include/globalvars.h
> ===================================================================
> --- include/globalvars.h	(revision 828)
> +++ include/globalvars.h	(working copy)
> @@ -31,6 +31,10 @@
>  #include <amd_geodelx.h>
>  #endif
>  
> +#ifdef CONFIG_BOARD_EMULATION_QEMU_X86
> +#include <qemu.h>
> +#endif
> +
>  /*
>   * struct global_vars is managed entirely from C code. Keep in mind that there
>   * is NO buffer at the end of the struct, so having zero-sized arrays at the
> Index: include/arch/x86/qemu.h
> ===================================================================
> --- include/arch/x86/qemu.h	(revision 0)
> +++ include/arch/x86/qemu.h	(revision 0)
> @@ -0,0 +1,40 @@
> +/*
> + * This file is part of the coreboot project.
> + *
> + * Copyright (C) 2008 Ronald G. Minnich <rminnich at gmail.com>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
> + */
> +
> +#ifndef CPU_QEMU_H
> +#define CPU_QEMU_H
> +
> +
> +#ifndef __ASSEMBLER__
> +
> +/* This is new. 
> + * We're not using it yet. 
> + * K8 requires it and, for future ports, we are going to require it. 
> + * it's a useful placeholder for platform info that usually ends up 
> + * scattered everywhere. On K8, it is initially stored at the base of stack
> + * in cache-as-ram and then copied out once ram is started. 
>   

Replace the two lines above with the text below, please.

 * scattered everywhere. On K8, it is stored near the base of stack
 * in the global variable struct.


> + */
> +struct sys_info {
> +	int empty;
> +};
> +
> +#endif
> +
> +#endif
>   

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the coreboot mailing list