[coreboot] [PATCH] v3: fix stack underflow for i586 and GeodeLX

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Thu Aug 28 04:22:03 CEST 2008

On 28.08.2008 04:01, ron minnich wrote:
> Acked-by: Ronald G. Minnich <rminnich at gmail.com>

Forgive me, but I want to retract that patch. While it is correct, it is
a band-aid instead of a real fix.
Can't we determine init_detected from C code and avoid working with it
in asm?
The Fam10h BKDG states in section 2.3.1:
"determine the type of this reset. One method is to use [The Link
Initialization Control Register] F0x6C[InitDet] bit."
The same register is suggested by the Athlon64/Operon BKDG and the
Fam0fh BKDG.

That should work from C and make our lives easier. To be honest, I have
no idea why we use bit 11 of MTRRdefType_MSR for the init_detected purpose.



More information about the coreboot mailing list