[coreboot] patch for global variables

ron minnich rminnich at gmail.com
Thu Aug 28 00:48:02 CEST 2008

I responded as best I could.

On Wed, Aug 27, 2008 at 2:46 PM, Carl-Daniel Hailfinger
<c-d.hailfinger.devel.2006 at gmx.net> wrote:

>> Index: mainboard/amd/serengeti/mainboard.h
>> ===================================================================
>> --- mainboard/amd/serengeti/mainboard.h       (revision 826)
>> +++ mainboard/amd/serengeti/mainboard.h       (working copy)
>> @@ -31,3 +31,5 @@
>>  #define HT_CHAIN_END_UNITID_BASE 0x6
>>  #define SB_HT_CHAIN_ON_BUS0 2
>> +#define SERIAL_DEV W83627HF_SP1
>> +#define SERIAL_IOBASE 0x3f8

I moved these to the stage1.c as they are clearly stage1 things, not
mainboard.h things.

Good catch.

> I trust you to have good reasons for rearranging the include files.
> However, if our include files are indeed order sensitive, we ought to
> fix them.

I undid this change, sorry for it.

>>  void hardware_stage1(void)
>>  {
>> +     void w83627hf_enable_serial(u8 dev, u8 serial, u16 iobase);
> That declaration should be in superio/winbond/w83627hf/w83627hf.h,
> otherwise there's no reason to include it. Please remove the line above.

It's a stage1 thing. Not removed it, corrections welcome.

> Same comment about include order.

damn, I just realized I missed this one. We can fix it.

I would actually like to have mainboard.h include all things known to
be needed for the mainboard, it would reduce all this #include


More information about the coreboot mailing list