[coreboot] [PATCH] Re: LZMA magic number

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Wed Aug 27 23:48:26 CEST 2008


On 27.08.2008 23:39, Myles Watson wrote:
>> -----Original Message-----
>> From: Ward Vandewege [mailto:ward at gnu.org]
>> Sent: Wednesday, August 27, 2008 3:31 PM
>> To: Myles Watson
>> Cc: 'Carl-Daniel Hailfinger'; coreboot at coreboot.org
>> Subject: Re: [coreboot] [PATCH] Re: LZMA magic number
>>
>> On Wed, Aug 27, 2008 at 03:22:38PM -0600, Myles Watson wrote:
>>     
>>> I like the idea of assuming no compression if uncompressing it fails.  I
>>> wonder if it would be better to copy it to dest instead of running it in
>>> place.
>>>       
>> If compression is disabled in Config.lb the current code runs it in place
>> as
>> well. So I guess it's no problem?
>>     
>
> Ward,
>
> I should have checked that.
>
> Acked-by: Myles Watson <mylesgw at gmail.com>
>   

The change looks sensible to me. Since it is tested, here is my ack.
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the coreboot mailing list